Restore P13 Monticello Epicea events on Pharo 14#2
Closed
Gabriel-Darbord wants to merge 1 commit into
Closed
Conversation
Gabriel-Darbord
force-pushed
the
codex/pharo14-epicea-monticello-surface
branch
from
d38ede6 to
9818e32
Compare
Co-authored-by: Codex <codex@openai.com>
Gabriel-Darbord
force-pushed
the
codex/pharo14-epicea-monticello-surface
branch
from
9818e32 to
450528c
Compare
Member
Author
|
Closing this direction. The missing classes are not renamed Pharo 14 APIs; P14 removed the Monticello Epicea event mechanism. We will keep the P12/P13 MCP extensions in an MCP conditional package instead of restoring removed P14 classes in PharoCompatibility. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EpMonticelloVersionSaveandEpMonticelloVersionsLoadEpicea event classes in the Pharo 14 implementation ofPharo13SurfaceContext
MCP loads
PharoCompatibilitywithPharo13Surfacebefore loading its own package. On Pharo 14,MCPackageLoader>>warnAboutDependenciesreported missing extension targets forEpMonticelloVersionSaveandEpMonticelloVersionsLoad. Pharo 14 removed those concrete classes while still keeping the visitor hooks/predicates, so the compatibility surface restores the missing P13 event contracts.Verification
PharoCompatibilityP13SurfacePharo14Test>>testInstallPharo13SurfaceProvidesMonticelloEpiceaEventspassed in P14PharoCompatibilityP13SurfacePharo14Testpassed in P14git diff --cached --checkpassed before commit